Skip to content

feat: implement new "Info" tabs for all object types in the database tree#4136

Open
kkdras wants to merge 24 commits into
mainfrom
kkdras.3681
Open

feat: implement new "Info" tabs for all object types in the database tree#4136
kkdras wants to merge 24 commits into
mainfrom
kkdras.3681

Conversation

@kkdras

@kkdras kkdras commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Resolves #3681
Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
778 772 0 6 0
Test Changes Summary ✨7 🗑️2

✨ New Tests (7)

  1. Info tab omits undefined schema metadata (tenant/diagnostics/tabs/info.test.ts)
  2. Info tab displays schema metadata for administrators (tenant/diagnostics/tabs/info.test.ts)
  3. Streaming Query Info remains available when describe fails (tenant/diagnostics/tabs/info.test.ts)
  4. View Info includes YQL code preview (tenant/diagnostics/tabs/info.test.ts)
  5. Navigation v2 renders only the tree in Object Summary (tenant/summary/objectSummary.test.ts)
  6. Legacy navigation renders only the tree for schema objects (tenant/summary/objectSummary.test.ts)
  7. Info panel collapse and expand functionality in legacy navigation (tenant/summary/objectSummary.test.ts)

🗑️ Deleted Tests (2)

  1. Primary keys header is visible in Schema tab (tenant/summary/objectSummary.test.ts)
  2. Info panel collapse and expand functionality (tenant/summary/objectSummary.test.ts)

Bundle Size: 🔺

Current: 64.45 MB | Main: 64.43 MB
Diff: +0.02 MB (0.03%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@kkdras

kkdras commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review
@greptile review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d64612cebb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/containers/Tenant/Diagnostics/Overview/Overview.tsx
Comment thread src/containers/Tenant/Diagnostics/Overview/Overview.tsx
Comment thread src/containers/Tenant/Diagnostics/Overview/TopicInfo/TopicInfo.tsx Outdated
@kkdras

kkdras commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review
@greptile review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8dfad5bbf2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/containers/Tenant/Diagnostics/Overview/Overview.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d7eeeebde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@astandrik astandrik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for two user-visible regressions:

  1. ID and Version are now exposed to non-administrators despite the acceptance contract in #3681.
  2. Streaming-query details now depend on generic describe succeeding, even though their dedicated request can succeed independently.

Please address the inline comments and add regression coverage for both cases.

Comment thread src/containers/Tenant/Diagnostics/Overview/Overview.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e0a081b7c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/containers/Tenant/Diagnostics/Overview/Overview.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 926dd2fcd7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@astandrik
astandrik self-requested a review July 25, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement new "Info" tabs for all object types in the database tree

2 participants